[CK_TILE] Add GetName for GEMM kernels #1791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledudek
requested review from
junliume,
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca and
afagaj
as code owners
afagaj
reviewed
Jan 3, 2025
aosewski
requested changes
Jan 8, 2025
There was a problem hiding this comment.
I think it would be beneficial to make it much more comprehensive. Lets add also the size of warp tiles next to block tile. Additionally I'd add similar functions to Pipelines and block gemms, so that later on during benchmarking we could easily get report with what instance we're working on.
aosewski
reviewed
Jan 15, 2025
| #include <string> | ||
|
|
||
| #include "ck_tile/core.hpp" | ||
| namespace ck_tile { |
| using _SS_ = std::string; | ||
|
|
||
| return _SS_("pipeline_AgBgCrCompV3_") + | ||
| _TS_(MPerBlock) + "x" + _TS_(NPerBlock) + "x" + _TS_(KPerBlock) + "x" + _TS_(BlockSize) + "_" + |
There was a problem hiding this comment.
There's no need to duplicate MPerBlock , NPerBlock KPerBLock info here. It's in Tile Shape
| using _SS_ = std::string; | ||
|
|
||
| return _SS_("gemm_problem_") + | ||
| _TS_(VectorLoadSize) + "x" + _TS_(kBlockSize) + "_" + |
There was a problem hiding this comment.
We would need here scheduler info also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add GetName for GEMM kernels to easily print its name and a few other details.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
Small change. I am also open to print other kernel parameters.