Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CK-Tile Grouped GEMM refactor and post PR fixes #1756

Merged
merged 29 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
44fae39
Grouped gemm simple code refactor
mozga-amd Dec 17, 2024
dc48a14
Offset invoker
mozga-amd Jan 5, 2025
5df59d5
Merge remote-tracking branch 'origin/develop' into mozga-amd/gemm_ref…
mozga-amd Jan 5, 2025
ae36a63
Invoke generic Run, and replace name of parrtitioner variable
mozga-amd Jan 6, 2025
cbba680
Tests fix type
mozga-amd Jan 6, 2025
b781628
Removed namespaces
mozga-amd Jan 7, 2025
774f903
Add template param to avoid implicit cast
mozga-amd Jan 7, 2025
0c8a579
Remove generic function
mozga-amd Jan 7, 2025
2f80a6a
Constant value
mozga-amd Jan 7, 2025
e8da31e
underline enum to int16_t
mozga-amd Jan 14, 2025
bdc17fb
Generalize partitioner function
mozga-amd Jan 15, 2025
56c1916
Remove whitespaces
mozga-amd Jan 15, 2025
5aa63ce
Rename function
mozga-amd Jan 15, 2025
a0cffd8
Using support
mozga-amd Jan 15, 2025
414328c
Clang-format
mozga-amd Jan 15, 2025
2ac3b7f
Clang-format
mozga-amd Jan 15, 2025
b72d199
Fn-partitioner description fn
mozga-amd Jan 16, 2025
f70d888
Merge remote-tracking branch 'origin/develop' into mozga-amd/gemm_ref…
mozga-amd Jan 16, 2025
faad6fc
Typo
mozga-amd Jan 16, 2025
3fc0b87
Typo 2
mozga-amd Jan 16, 2025
60ee8fa
Better description
mozga-amd Jan 16, 2025
997bce8
Merge remote-tracking branch 'origin/develop' into mozga-amd/gemm_ref…
mozga-amd Jan 20, 2025
ccc19d6
Better description
mozga-amd Jan 20, 2025
189cfa7
Refactor after review
mozga-amd Jan 20, 2025
66d8b6b
Use ctr instead of set fn
mozga-amd Jan 20, 2025
d78b2df
Inovke ctr and typo
mozga-amd Jan 20, 2025
ceaf540
Comments
mozga-amd Jan 21, 2025
92a369e
Remove unnecessary comment
mozga-amd Jan 21, 2025
4735476
Review, remove modulo
mozga-amd Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better description
mozga-amd committed Jan 16, 2025
commit 60ee8fad6b34a94d2e8c8a8debdc52754af32d4f
4 changes: 2 additions & 2 deletions include/ck_tile/ops/gemm/kernel/gemm_tile_partitioner.hpp
Original file line number Diff line number Diff line change
@@ -126,8 +126,8 @@ template <typename PartitionerFn,
typename = typename std::enable_if_t<HasFnOneArgImpl<PartitionerFn>{}>>
struct OffsetCallculation1DPartitioner
mozga-amd marked this conversation as resolved.
Show resolved Hide resolved
{
/// @brief Returns a `tuple` [Im, In] shifted index, used to calculate 1d-tile index.
// Note: The function subtracts the block's start (offset).
/// @brief Returns a `tuple` [Im, In] shifted index, used to shift 1d-tile index.
// Note: The function subtracts the block's start (offset) from 1D raw-indexes.
[[nodiscard]] CK_TILE_DEVICE static constexpr auto
GetOffsetedTileIndex(index_t block_start) noexcept -> const tuple<index_t, index_t>
{