Skip to content

Commit

Permalink
Documentation - Standardization (#1220)
Browse files Browse the repository at this point in the history
* Add version number to documentation left navigation bar

* Add an 'About' section with a license page

* Rename .sphinx directory to sphinx

* Update rocm-docs-core dependency

* Update labels in dependabot config

* Update build.os and requirements in rtd yaml config

* Add caption to toc
  • Loading branch information
samjwu authored and kiritigowda committed Oct 23, 2023
1 parent fc86891 commit 587eb32
Show file tree
Hide file tree
Showing 9 changed files with 34 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
version: 2
updates:
- package-ecosystem: "pip" # See documentation for possible values
directory: "/docs/.sphinx" # Location of package manifests
directory: "/docs/sphinx" # Location of package manifests
open-pull-requests-limit: 10
schedule:
interval: "daily"
target-branch: "develop"
labels:
- "docs"
- "dependencies"
- "noCI"
- "ci:docs-only"
reviewers:
- "samjwu"
4 changes: 2 additions & 2 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ formats: [htmlzip]

python:
install:
- requirements: docs/.sphinx/requirements.txt
- requirements: docs/sphinx/requirements.txt

build:
os: ubuntu-20.04
os: ubuntu-22.04
tools:
python: "3.8"
apt_packages:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Run the steps below to build documentation locally.
* sphinx documentation
```Bash
cd docs
pip3 install -r .sphinx/requirements.txt
pip3 install -r sphinx/requirements.txt
python3 -m sphinx -T -E -b html -d _build/doctrees -D language=en . _build/html
```
* Doxygen
Expand Down
2 changes: 0 additions & 2 deletions docs/.sphinx/requirements.in

This file was deleted.

21 changes: 19 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
# https://www.sphinx-doc.org/en/master/usage/configuration.html

import os
from rocm_docs import ROCmDocs
import re

from rocm_docs import ROCmDocs

external_projects_current_project = "mivisionx"

Expand All @@ -42,7 +43,23 @@
print(f"cp {file_path[:-1]} {file_path[1:]}")
os.system(f"cp {file_path[:-1]} {file_path[1:]}")

docs_core = ROCmDocs("MIVisionX Documentation")
with open("../CMakeLists.txt", encoding="utf-8") as f:
match = re.search(r"set\(VERSION\s+\"?([0-9.]+)[^0-9.]+", f.read())
if not match:
raise ValueError("VERSION not found!")
version_number = match[1]
left_nav_title = f"MIVisionX {version_number} Documentation"

# for PDF output on Read the Docs
project = "MIVisionX Documentation"
author = "Advanced Micro Devices, Inc."
copyright = "Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved."
version = version_number
release = version_number

external_toc_path = "./sphinx/_toc.yml"

docs_core = ROCmDocs(left_nav_title)
docs_core.run_doxygen(doxygen_root="doxygen", doxygen_path="doxygen/xml")
docs_core.enable_api_reference()
docs_core.setup()
Expand Down
4 changes: 4 additions & 0 deletions docs/license.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# License

```{include} ../LICENSE.txt
```
3 changes: 3 additions & 0 deletions docs/.sphinx/_toc.yml.in → docs/sphinx/_toc.yml.in
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,6 @@ subtrees:
- file: docker/pytorch/README
- file: docker/tensorflow/README
- file: CHANGELOG
- caption: About
entries:
- file: license
2 changes: 2 additions & 0 deletions docs/sphinx/requirements.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rocm-docs-core[api_reference]==0.26.0

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile requirements.in
Expand Down

0 comments on commit 587eb32

Please sign in to comment.