InlineVector implementation #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novakovicdj
requested review from
BrianHarrisonAMD,
junliume and
BradPepersAMD
as code owners
CAHEK7
suggested changes
Dec 3, 2024
DrizztDoUrden
requested changes
Dec 3, 2024
CAHEK7
reviewed
Dec 3, 2024
src/include/miopen/inline_vector.hpp
Outdated
| std::copy(data.begin(), data.end(), storage.begin()); | ||
| } | ||
|
|
||
| template <typename _InputIterator, typename = std::_RequireInputIter<_InputIterator>> |
There was a problem hiding this comment.
_RequireInputIter is gcc/clang specific.
I guess that part can be omitted at all:
template <typename InputIterator>
|
After develop fix, looks like there is this hip tidy error: [2024-12-03T18:18:41.307Z] test/gtest/inline_vector_basic_ops.cpp:54:1: warning: syntax error [syntaxError] |
DrizztDoUrden
requested changes
Dec 4, 2024
DrizztDoUrden
requested changes
Dec 4, 2024
CAHEK7
approved these changes
Dec 10, 2024
|
@BrianHarrisonAMD @BradPepersAMD @junliume we need this PR for host-side performance improvements (especially around rnn/lstm networks, which is, as I remember, quite critical) |
DrizztDoUrden
approved these changes
Jan 8, 2025
|
Starting CI for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR for initial implementation of
InlineVectorclass from issue #3408, also added some tests for this.I will do additional performance testing with tensorOp solver structure to check if, and how much, host time is reduced using
InlineVectorinstead ofstd::vectorfor lens/strides inTensorDescriptor