-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NLLLoss #3168
base: develop
Are you sure you want to change the base?
Implement NLLLoss #3168
Conversation
…o impl_NLLLoss
docs/reference/index.rst
Outdated
@@ -38,3 +38,4 @@ The MIOpen API library is structured as follows: | |||
* :doc:`RotaryPositionalEmbeddings <../doxygen/html/group__RotaryPositionalEmbeddings>` (experimental) | |||
* :doc:`ReLU <../doxygen/html/group___re_l_u>` (experimental) | |||
* :doc:`GLU <../doxygen/html/group__glu>` (experimental) | |||
* :doc:`NLLLoss<../doxygen/html/group__nllloss>` (experimental) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a space between NLLLoss
and <...>
. It should be * :doc:`NLLLoss <../doxygen/html/group__nllloss>` (experimental)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed log:
3168_error_log.txt
.githooks/pre-commit
Outdated
@@ -40,4 +40,3 @@ do | |||
"$format" -i -style=file "$file" | |||
fi | |||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an unexpected modification?
I found a bug, need to fix it before re-open |
Nllloss float16
Nllloss float32
Nllloss bfloat16
Contiguous :
Non-Contiguous :
Reduction:
This result does not include some instances where MIOpen significantly outperforms ROCm in cases with a large number of classes:
Input size = [8192 52100] (N, C)
Input size = [20480 50000] (N, C)