Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable the transform tensor API to convert any NCHW tensor to NHWC tensor and vice versa #2003

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

dmikushin
Copy link
Contributor

LWPMIOPEN-125

We substitute the TensorTransfom implementation with a more generic GPU-based gpuTT library calls.

Few things still to be implemented:

  • Support non-equal input and output types
  • Support for alpha and beta in the case of a simple copy (i.e., perm = identity) is still missing
  • The test should randomly transpose the input tensors, so that TensorTransform could transpose them back

@dmikushin dmikushin marked this pull request as draft February 28, 2023 17:41
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that gputt cannot be used with OCL backend. If so then please use conditional compilation (see config.h) as needed.

return a.first < b.first;
});

printf("Permutation for %s -> %s: ", src_layout.c_str(), dst_layout.c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use MIOPEN_LOG_I2/I/W/E macros, no printf please.

@JehandadKhan JehandadKhan self-requested a review May 5, 2023 16:41
dmikushin added 13 commits June 5, 2023 11:52
…nstall the extra gputt dependency. It should be built like this:

  BUILDKIT_PROGRESS=plain docker build --no-cache -f Dockerfile.gputt -t rocm/miopen:ci-gputt .

Then the usual miopen:ci invocation should instead use miopen:ci-gputt:

  docker run -it -v $HOME:$HOME --privileged --rm --device=/dev/kfd --device /dev/dri:/dev/dri:rw  --volume /dev/dri:/dev/dri:rw -v /var/lib/docker/:/var/lib/docker --group-add video --cap-add=SYS_PTRACE --security-opt seccomp=unconfined rocm/miopen:ci-gputt fish
@dmikushin dmikushin force-pushed the enable-hchw-nhwc-conversion branch from f1d20f7 to c686acf Compare June 5, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants