[HIPIFY][#782][#783][feature] Initial hipification support for overloaded CUDA functions #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r CUDA overloaded functions [IMP] + Introduced 1-to-N hipification for overloaded APIs with different number of arguments (see the `cudaEventCreate` example in ROCm#783) + Introduced a new marker `CUDA_OVERLOADED` and the corresponding Matcher `cudaOverloadedHostFuncCall` + Currently, `CUDA_OVERLOADED` APIs are hipified twice: first, by rewriting string blindly, and second, by overload matcher (correcting) + Added a synthetic test for cudaEventCreate to `hipEventCreateWithFlags` hipification in `runtime_functions.cu` [ToDo] + Take into account other markers, firstly `HIP_UNSUPPORTED`, in overloaded hipification + Take into account `CUDA_VERSION` for overloaded APIs: currently, versioning is provided only for a single instance of the overloaded API + Find all the existing overloaded CUDA APIs, update HIPIFY correspondingly for those APIs, and provide tests + [sub-task] Implement overloading with the same number of arguments and different argument types + [optionally] Think about implementing the same in hipify-perl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP]
cudaEventCreateexample in [HIPIFY][#782][SWDEV-382258][feature] C vs C++ API distinguishing #783)CUDA_OVERLOADEDand the corresponding MatchercudaOverloadedHostFuncCallCUDA_OVERLOADEDAPIs are hipified twice: first, by rewriting string blindly, and second, by overload matcher (correcting)hipEventCreateWithFlagshipification inruntime_functions.cu[ToDo]
HIP_UNSUPPORTED, in overloaded hipificationCUDA_VERSIONfor overloaded APIs: currently, versioning is provided only for a single instance of the overloaded API