Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP environment variables #3515

Merged
merged 1 commit into from
Nov 5, 2024
Merged

HIP environment variables #3515

merged 1 commit into from
Nov 5, 2024

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented Jun 6, 2024

The important HIP env variables.

@neon60 neon60 changed the base branch from develop to docs/develop June 6, 2024 18:02
@neon60 neon60 requested a review from lpaoletti June 6, 2024 18:03
@neon60 neon60 marked this pull request as draft June 6, 2024 18:10
@neon60 neon60 mentioned this pull request Jun 6, 2024
Open
@neon60 neon60 marked this pull request as ready for review June 7, 2024 08:41
@neon60 neon60 force-pushed the hip_env_variables branch 2 times, most recently from 77517f1 to 3fd0c3e Compare June 8, 2024 12:13
@neon60 neon60 force-pushed the hip_env_variables branch 3 times, most recently from b140b3d to 66ccac6 Compare October 2, 2024 21:52
cjatin
cjatin reviewed Oct 25, 2024
View reviewed changes
docs/how-to/debugging_env.rst Outdated Show resolved Hide resolved
docs/how-to/debugging_env.rst Outdated Show resolved Hide resolved
docs/how-to/debugging_env.rst Show resolved Hide resolved
@neon60 neon60 force-pushed the hip_env_variables branch 5 times, most recently from ec608c5 to 599fb5f Compare October 28, 2024 15:03
@neon60 neon60 requested a review from cjatin October 28, 2024 15:54
@neon60 neon60 force-pushed the hip_env_variables branch 2 times, most recently from c2adf92 to d242004 Compare October 31, 2024 19:22
cjatin
cjatin reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@cjatin cjatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, LGTM otherwise.

docs/reference/env_variables.rst Outdated
- None
- ``--gpu-architecture=gfx906:sramecc+:xnack``, ``-fgpu-rdc``

* - | ``DEBUG_HIP_GRAPH_DOT_PRINT``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this. AFAIK this is meant for developers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@neon60 neon60 requested a review from cjatin November 5, 2024 08:00
@neon60 neon60 merged commit d187943 into docs/develop Nov 5, 2024
4 checks passed
@neon60 neon60 deleted the hip_env_variables branch November 6, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleelk saleelk saleelk left review comments

@cjatin cjatin cjatin approved these changes

@randyh62 randyh62 randyh62 approved these changes

@lpaoletti lpaoletti Awaiting requested review from lpaoletti

@matyas-streamhpc matyas-streamhpc Awaiting requested review from matyas-streamhpc

@parbenc parbenc Awaiting requested review from parbenc

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neon60 @saleelk @randyh62 @cjatin @lpaoletti