Create op builders (1.) #4005
Open
Create op builders (1.) #4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: conflict was due to a new parser option for gelu called "QuickGelu". as a resolution a new op_builder called gelu_quick was introduced
CharlieL7
reviewed
May 14, 2025
|
As a general note, please update license on files changed/added to 2025. |
CharlieL7
requested changes
May 19, 2025
CharlieL7
reviewed
May 19, 2025
src/onnx/parse_batchnorm.cpp
Outdated
| @@ -37,61 +36,15 @@ struct parse_batchnorm : op_parser<parse_batchnorm> | |||
| instruction_ref parse(const op_desc& /*opd*/, | |||
| const onnx_parser& parser, | |||
| const onnx_parser::node_info& info, | |||
| std::vector<instruction_ref> args) const | |||
| const std::vector<instruction_ref>& args) const | |||
| { | |||
| float epsilon = 1e-5f; | |||
There was a problem hiding this comment.
The default attribute value is set in parse_... and in the op builder. This might lead to some unintuitive behavior should someone try to change it in the op builder. Probably better to have a conditional here and use the default in the op builder.
CharlieL7
reviewed
May 19, 2025
…nction more flexible to changes
…rt_literal with add_literal
…oo; modifying insert_literal to add_literal
CharlieL7
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR related to op builders.