Avoid dynamic memory allocation in kernel launch #3861
+88
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3861 +/- ##
========================================
Coverage 92.41% 92.41%
========================================
Files 520 520
Lines 22471 22478 +7
========================================
+ Hits 20766 20774 +8
+ Misses 1705 1704 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kahmed10
approved these changes
Mar 8, 2025
ahsan-ca
approved these changes
Mar 10, 2025
| @@ -551,14 +556,28 @@ std::vector<argument> generic_eval(const program& p, | |||
| F trace) | |||
| { | |||
| const module* mm = p.get_main_module(); | |||
| return generic_eval(mm, ctx, params, {}, trace); | |||
| std::size_t n = p.total_instructions(); | |||
| std::vector<char> buffer(n * (sizeof(instruction_ref) + sizeof(argument)) * 4); | |||
There was a problem hiding this comment.
Raw constants (e.g. 4 here) create a mystery.
| std::vector<argument> values; | ||
| values.reserve(16); | ||
| for(auto ins : iterator_for(*mod)) | ||
| { | ||
| assert(results.find(ins) == results.end()); | ||
| assert(mod->name() != "main" or results.find(ins) == results.end()); | ||
| #ifndef NDEBUG |
There was a problem hiding this comment.
Please add a comment here, for the uninitiated, why is this under a flag. Thanks.
| @@ -462,24 +463,27 @@ template <class F> | |||
| std::vector<argument> generic_eval(const module* mod, | |||
| std::vector<context>& ctx, | |||
| std::unordered_map<std::string, argument> params, | |||
| std::unordered_map<instruction_ref, argument> results, | |||
| std::pmr::unordered_map<instruction_ref, argument>& results, | |||
There was a problem hiding this comment.
The line above can take an efficiency gain of using a const reference: i.e. for const std::unordered_map<std::string, argument> & params', as for results`.
|
@pfultz2 just need to fix the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.