Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory_coloring pass when MIGRAPHX_NSTREAMS > 2 #3757

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix memory_coloring pass when MIGRAPHX_NSTREAMS > 2 #3757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e23878
Fix memory_coloring pass when MIGRAPHX_NSTREAMS > 2
kahmed10 Jan 11, 2025
be58a75
update copyright and add test case
kahmed10 Jan 15, 2025
031d500
update test copyright
kahmed10 Jan 15, 2025
eb3d71e
Merge branch 'develop' of https://github.com/ROCm/AMDMIGraphX into me…
kahmed10 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/memory_coloring.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -177,9 +177,9 @@ struct allocation_segment
{
assert(ins->get_shape().bytes() > 0);
// Compute alignment
auto n = 1 + (ins->get_shape().bytes() - 1) / alignment;
std::size_t n = 1 + (ins->get_shape().bytes() - 1) / alignment;
assert(n > 0);
auto start = 0;
std::size_t start = 0;
// Insert at end if it cant fit at the begining
if(segments.empty() or segments.begin()->first <= n)
{
Expand Down
16 changes: 15 additions & 1 deletion test/memory_coloring_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* The MIT License (MIT)
*
* Copyright (c) 2015-2023 Advanced Micro Devices, Inc. All rights reserved.
* Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -3805,4 +3805,18 @@ TEST_CASE(test_tuple)
CHECK(is_disjoint({a1, a2}));
}

TEST_CASE(test_large_offsets)
{
migraphx::module m;

auto a1 = add_alloc(m, {migraphx::shape::float_type, {10000000000}});
auto m1 = m.add_instruction(pass_op{}, a1);
auto a2 = add_alloc(m, {migraphx::shape::float_type, {10000000000}});
m.add_instruction(pass_op{}, a2, m1);
run_pass(m);
CHECK(m.get_parameter_shape("scratch").bytes() == 80000000000);
CHECK(no_allocate(m));
CHECK(is_disjoint({a1, a2}));
}

int main(int argc, const char* argv[]) { test::run(argc, argv); }
Loading