Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes for contiguous transpose gemm fusion for hipblaslt #3706

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

ahsan-ca
Copy link
Contributor

No description provided.

@ahsan-ca ahsan-ca added enhancement New feature or request Perf Improve labels Dec 11, 2024
@ahsan-ca ahsan-ca self-assigned this Dec 11, 2024
@ahsan-ca ahsan-ca requested a review from causten as a code owner December 11, 2024 19:58
@ahsan-ca ahsan-ca linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (0860461) to head (3926315).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3706   +/-   ##
========================================
  Coverage    92.23%   92.23%           
========================================
  Files          514      514           
  Lines        21746    21746           
========================================
  Hits         20057    20057           
  Misses        1689     1689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
392631
Rate old
6f6705
Diff Compare
torchvision-resnet50 64 3,254.81 3,257.99 -0.10%
torchvision-resnet50_fp16 64 6,979.06 6,969.89 0.13%
torchvision-densenet121 32 2,433.94 2,434.72 -0.03%
torchvision-densenet121_fp16 32 4,061.77 4,079.58 -0.44%
torchvision-inceptionv3 32 1,628.10 1,625.71 0.15%
torchvision-inceptionv3_fp16 32 2,747.02 2,744.57 0.09%
cadene-inceptionv4 16 765.30 764.53 0.10%
cadene-resnext64x4 16 812.77 812.65 0.01%
slim-mobilenet 64 7,466.82 7,463.64 0.04%
slim-nasnetalarge 64 208.98 209.02 -0.02%
slim-resnet50v2 64 3,438.94 3,438.27 0.02%
bert-mrpc-onnx 8 1,148.38 1,150.14 -0.15%
bert-mrpc-tf 1 477.99 473.42 0.97%
pytorch-examples-wlang-gru 1 525.61 412.17 27.52% 🔆
pytorch-examples-wlang-lstm 1 394.77 393.10 0.42%
torchvision-resnet50_1 1 784.75 790.72 -0.75%
cadene-dpn92_1 1 401.73 399.49 0.56%
cadene-resnext101_1 1 381.57 383.53 -0.51%
onnx-taau-downsample 1 346.07 345.20 0.25%
dlrm-criteoterabyte 1 33.32 33.32 -0.03%
dlrm-criteoterabyte_fp16 1 52.71 52.75 -0.06%
agentmodel 1 8,366.66 8,373.46 -0.08%
unet_fp16 2 58.75 58.79 -0.07%
resnet50v1_fp16 1 912.98 969.89 -5.87% 🔴
resnet50v1_int8 1 1,011.16 1,031.16 -1.94%
bert_base_cased_fp16 64 1,169.86 1,170.20 -0.03%
bert_large_uncased_fp16 32 363.27 362.80 0.13%
bert_large_fp16 1 198.50 199.81 -0.65%
distilgpt2_fp16 16 2,199.51 2,195.15 0.20%
yolov5s 1 527.70 534.95 -1.35%
tinyllama 1 43.39 43.65 -0.62%
vicuna-fastchat 1 179.39 174.76 2.65%
whisper-tiny-encoder 1 417.70 417.83 -0.03%
whisper-tiny-decoder 1 428.05 425.41 0.62%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit b0072d9 into develop Dec 14, 2024
42 of 45 checks passed
@causten causten deleted the hipblaslt-contiguous-transpose branch December 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Perf Improve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fusion for Contiguous Transpose Gemm for hipBLASLt
4 participants