-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mxr to onnx #3682
Merged
Merged
mxr to onnx #3682
+232
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3682 +/- ##
========================================
Coverage 92.16% 92.16%
========================================
Files 515 515
Lines 21978 21978
========================================
Hits 20256 20256
Misses 1722 1722 ☔ View full report in Codecov by Sentry. |
pfultz2
reviewed
Dec 15, 2024
pfultz2
reviewed
Dec 15, 2024
pfultz2
reviewed
Dec 15, 2024
pfultz2
reviewed
Dec 15, 2024
pfultz2
reviewed
Dec 15, 2024
pfultz2
reviewed
Dec 15, 2024
pfultz2
requested changes
Dec 20, 2024
pfultz2
reviewed
Dec 20, 2024
pfultz2
reviewed
Dec 20, 2024
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
pfultz2
reviewed
Jan 7, 2025
pfultz2
approved these changes
Jan 7, 2025
causten
pushed a commit
that referenced
this pull request
Jan 24, 2025
torch-migraphx sometimes expects default python object comparison in if-else trees when working with instruction_refs. This should keep the correct behavior added by #3682 but add fallback for when not comparing 2 instruction_refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to migraphx_py to expose information about instruction_ref to engineer ONNX file.