Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating generic_float struct for adding datatypes #3522
Integrating generic_float struct for adding datatypes #3522
Changes from 6 commits
c51c1ce
134b408
d4fa6eb
0b60841
7a646f1
ebe819b
379a77a
174384c
787b651
1d1fa1c
1791092
a2eb005
ff8ffc7
e36fd65
9ac4e2a
f05fd31
cb4d92d
0cc1946
85a761b
65cf9ae
fbabf54
549f5e6
d302e5d
8d475e3
a0fd055
41379fe
0c29c7b
4b012a8
dbaa3a8
b2bd2a0
6f328f0
e6d9763
6538050
4e96d4d
ef11f1f
e4a25bd
3354c6e
6de079b
7750874
801f485
33e2c8d
9bb7198
b3c345d
03df6f9
ad817b2
898417b
aa5b9c9
6f72370
0aab1a0
a337b16
894ed7f
4895a68
b129bd5
0463266
2e3bd25
ff3566e
c02f3e3
99802b9
2db6e41
b195514
5754c1c
34554fb
56cdd29
9ae05ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 31 in src/include/migraphx/generic_float.hpp
Check warning on line 172 in src/include/migraphx/generic_float.hpp
Check warning on line 180 in src/include/migraphx/generic_float.hpp
Check warning on line 267 in src/include/migraphx/generic_float.hpp
Check warning on line 268 in src/include/migraphx/generic_float.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
ifdef
on L45 do? If that is removed, could we remove the<half/half.hpp>
include here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think we should remove
<half/half.hpp>
includes everywhere from migraphx, and we can remove the ifdef from below.Check warning on line 69 in src/include/migraphx/half.hpp
Check warning on line 75 in src/include/migraphx/half.hpp
Check warning on line 96 in src/include/migraphx/half.hpp
Check warning on line 100 in src/include/migraphx/half.hpp
Check warning on line 104 in src/include/migraphx/half.hpp