-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FP8 ONNX tests #3041
Add FP8 ONNX tests #3041
Conversation
f74f9d2
to
5de8fb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
+ Coverage 91.97% 91.98% +0.01%
===========================================
Files 489 489
Lines 19398 19398
===========================================
+ Hits 17841 17844 +3
+ Misses 1557 1554 -3 ☔ View full report in Codecov by Sentry. |
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a next part we should cover more operators for the "verification".
e.g. "reduction" operations like reduce_max, reduce_sum, avgpool, maxpool
math operations like sine, cosine, sqrt etc.
binary ops : division and multiplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address Umang's comment and should be good to go
83e9726
to
0c078b1
Compare
This reverts commit 1927b3e.
This PR adds ONNX tests for FP8.