Device kernels using FP8 #2510
Merged
Device kernels using FP8 #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umangyadav
force-pushed
the
device_fp8
branch
from
570a7c8 to
913ab6a
Compare
umangyadav
force-pushed
the
device_fp8
branch
from
913ab6a to
66db3c2
Compare
pfultz2
approved these changes
Dec 5, 2023
TedThemistokleous
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #2473
Device kernels doesn't have support for FP8. therefore this PR makes use of eliminate_fp8 pass to convert inputs to float and converts back final result to fp8.
I've kept target branch to #2473 PR for now for easy review but that should change to develop once #2473 gets merged.