Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running individual passes in the driver #2413

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

pfultz2
Copy link
Collaborator

@pfultz2 pfultz2 commented Nov 8, 2023

No description provided.

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Nov 8, 2023

Test Batch Rate new
0164a3
Rate old
e3e005
Diff Compare
torchvision-resnet50 64 2,833.76 2,835.33 -0.06%
torchvision-resnet50_fp16 64 6,502.18 6,502.93 -0.01%
torchvision-densenet121 32 2,097.01 2,102.11 -0.24%
torchvision-densenet121_fp16 32 3,663.63 3,670.35 -0.18%
torchvision-inceptionv3 32 1,583.41 1,585.15 -0.11%
torchvision-inceptionv3_fp16 32 2,550.94 2,544.67 0.25%
cadene-inceptionv4 16 703.78 704.38 -0.09%
cadene-resnext64x4 16 692.80 692.95 -0.02%
slim-mobilenet 64 8,329.23 8,329.16 0.00%
slim-nasnetalarge 64 225.41 225.53 -0.06%
slim-resnet50v2 64 2,666.34 2,666.06 0.01%
bert-mrpc-onnx 8 822.65 823.30 -0.08%
bert-mrpc-tf 1 386.38 387.72 -0.35%
pytorch-examples-wlang-gru 1 299.02 302.79 -1.24%
pytorch-examples-wlang-lstm 1 313.53 311.08 0.79%
torchvision-resnet50_1 1 598.71 603.28 -0.76%
torchvision-inceptionv3_1 1 341.53 340.49 0.30%
cadene-dpn92_1 1 401.92 402.06 -0.04%
cadene-resnext101_1 1 329.62 326.46 0.97%
slim-vgg16_1 1 459.67 459.19 0.10%
slim-mobilenet_1 1 2,114.52 2,149.74 -1.64%
slim-inceptionv4_1 1 220.72 220.00 0.33%
onnx-taau-downsample 1 304.20 304.23 -0.01%
dlrm-criteoterabyte 1 21.58 21.60 -0.10%
dlrm-criteoterabyte_fp16 1 40.63 40.59 0.09%
agentmodel 1 5,871.89 6,000.46 -2.14%
unet_fp16 2 54.74 54.76 -0.03%
resnet50v1_fp16 1 937.13 948.30 -1.18%
bert_base_cased_fp16 64 903.29 903.25 0.00%
bert_large_uncased_fp16 32 285.64 285.67 -0.01%
bert_large_fp16 1 166.90 166.87 0.02%
distilgpt2_fp16 16 1,281.50 1,281.20 0.02%

This build is OK for merge ✅

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented Nov 8, 2023


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ torchvision-inceptionv3_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ slim-vgg16_1: PASSED: MIGraphX meets tolerance

     ✅ slim-mobilenet_1: PASSED: MIGraphX meets tolerance

     ✅ slim-inceptionv4_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large_uncased_fp16: PASSED: MIGraphX meets tolerance

     ✅ bert_large: PASSED: MIGraphX meets tolerance

🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

namespace driver {
inline namespace MIGRAPHX_INLINE_NS {

std::unordered_map<std::string, pass> create_passes_lookup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enumerating passes would add more maintenance. Can we create Registry of available passes ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try to do that in the future, but we would need to make the passes serializable, but I think thats beyond the scope of this PR.

Copy link
Contributor

@bpickrel bpickrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright date in all files

@causten causten requested a review from umangyadav November 20, 2023 19:36
@causten causten merged commit 93f8c81 into develop Dec 6, 2023
15 checks passed
@causten causten deleted the driver-passes branch December 6, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants