Feature: Added flutter internationalizing #128
Conversation
# Conflicts: # lib/constants/functions.dart # lib/custom_widgets/accounts_sum.dart # lib/pages/add_page/add_page.dart # lib/pages/structure.dart # pubspec.yaml
Votyer
changed the title
Votyer
changed the title
There was a problem hiding this comment.
Hi! I tried to run your changes and I noticed a few things. It seems to me that only a few things are translated while others are always kept in english which makes the app look a bit weird, some of these things are: dates, graphs page, "planned" and "planning" inside the Planning page, "Transactions" in the Transactions page.
Apart from this I tested the app on Android and it looks like the "Add transaction" page as some issue and throws an error (see the video below)
Screenrecorder-2023-12-24-12-13-53-775.mov
In the end I think that going forward with a complete translation of the app in Italian might be good but it will cost quite some time since we have smooth a lot of things out. I'll wait also for the opinion of @mikev-cw and @lucaantonelli
| @@ -0,0 +1,3 @@ | |||
| arb-dir: lib/l10n | |||
| template-arb-file: app_en.arb | |||
| output-localization-file: app_localizations.dart | |||
There was a problem hiding this comment.
When I run the main I get an error because it looks like that the word dashboard doesn't have a translation in the Italian file, you can check the missing words by adding here untranslated-messages-file: missingWords.txt
|
Same error of @theperu on the "Add" page.
Anyway I'm agreeding with this. This work is good enough and have all the "base things" we need, but it threatens to take away time from the milestones. Maybe we can speak on Discord about keeping this and go deeper, or park somewhere. |
|
@mikev-cw and @lucaantonelli the support for other languages is quite far in the future in my opinion so I think we should just close this and comeback to it once the app is more mature and stable. |
100% agreed. |
#112