Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2rust: Use released version #215

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Nov 4, 2022

This reduces the dependency on a particular GitHub branch that I was already about to remove after immunant/c2rust#693 was done.

Still marked as a draft as it depends on immunant/c2rust#690 (but that has all its blockers gone already).

@chrysn chrysn self-assigned this Nov 4, 2022
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@chrysn chrysn closed this Jan 17, 2023
@chrysn chrysn deleted the released-c2rust branch January 17, 2023 13:01
@chrysn chrysn restored the released-c2rust branch January 17, 2023 13:01
@chrysn
Copy link
Member Author

chrysn commented Jan 17, 2023

Reopening after accidentally having deleted the branch.

@chrysn chrysn reopened this Jan 17, 2023
@chrysn chrysn marked this pull request as ready for review February 2, 2023 07:57
@chrysn
Copy link
Member Author

chrysn commented Feb 2, 2023

Huh, saying that this is not where I'd have expected the error to show up would be putting it mildly -- I'm having a look at why this fails, but it may take a while.

@chrysn
Copy link
Member Author

chrysn commented Feb 2, 2023

I have no clue what caused the build failure, and can not reproduce the issue locally (after building the container in podman and using BOARDS="arduino-uno esp32-wroom-32 hifive1b msb-430h native samr21-xpro" make -C examples/rust-gcoap BUILD_IN_DOCKER=1 DOCKER=podman DOCKER_IMAGE=localhost/riotbuild:latest buildtest to run the very test that CI should have run).

Let's see if it was a random glitch (like, file system error?), restarting the build test.

@chrysn
Copy link
Member Author

chrysn commented Feb 3, 2023

Seems that builds break due to files left over from other runs. Switching to draft PR to prevent accidental merging just because a test happens to fix it.

@chrysn chrysn marked this pull request as draft February 3, 2023 06:36
@chrysn
Copy link
Member Author

chrysn commented Feb 3, 2023

I suspect now that this is due to changes in some base image, and would break in master just as well.

I still can't make progress for lack of a way to reproduce it (works locally), so I'm triggering a master rebuild to cut down the space.

.github/workflows/build.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants