Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to the projects #4

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Add icons to the projects #4

merged 7 commits into from
Sep 12, 2024

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Sep 12, 2024

indicating what they contain.

The PNGs are generated rather than hotlinked also to avoid data leakage, but most importantly because GitHub markdown doesn't have an option to give an image size for reused images.

@chrysn
Copy link
Member Author

chrysn commented Sep 12, 2024

@maribu, can you verify the properties? AIU your repos are under an open hardware license, while the miniloon has hardware provided but not under an OSHW license, might add an extra icon (or ask Lasse to clarify).

Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, please look inline, though.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@chrysn
Copy link
Member Author

chrysn commented Sep 12, 2024

Thanks, adjusted to your comments and merging.

I'd like to do better on the structuring front, but this will be tricky, for we can likely have any combination of properties.

@chrysn chrysn merged commit 3b313de into main Sep 12, 2024
2 checks passed
@chrysn chrysn deleted the logos branch September 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants