Fix failing spec05 and task02 test #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems there have been some failures mainly due to infrastructure. Specifically the samr21-xpro failing to flash will cause many reruns with the same faulty hardware. Previously it would just take the first available node in the list, which is deterministic but doesn't help with flakey test reruns. This may cause an issue with distance to other nodes, but if random selection of nodes becomes a problem we would have to introduce node pairing lists... Which is a bit more work. This is at least a first step.
Since the default numof addresses is 2 we should remove one assigned so we can add our own global
output when an address is assigned |
|
Ping @miri64 maybe it would be nice to look at this as well... Why would removing the TNT global address, then adding a known one prevent pinging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a border router running in the IOT lab infrastructure that is giving the test nodes an address.
See RIOT-OS/RIOT#20295 for some info.
While playing around with it I found that removing the address and adding in the spec address doesn't seem to work... Only changing
CONFIG_IEEE802154_DEFAULT_CHANNELso it never gets an address in the first place seems to make it function.Maybe we should be hardened against it but it would be nice to know why removing and shuffling the pan_id and channel doesn't allow it to work.