tests/sys/shell_lock: increase robustness of the test #20962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the test used the `help` command to verify that access to the
shell is present. While this does have the benefit of not requiring a
custom command, it does have some robustness issues:
- When new default commands get added, this test will fail
- When the help message of a command gets reworded, the test will fail
- When the order of commands in the test will change, the test will fail
- Note that with the XFA based `SHELL_COMMAND()` macro, we do not
guarantee any particular order. Specifically, the order can change
with implementation details.
maribu
added
Type: enhancement
maribu
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
benpicco
approved these changes
Nov 7, 2024
|
Thx a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Before the test used the
helpcommand to verify that access to the shell is present. While this does have the benefit of not requiring a custom command, it does have some robustness issues:SHELL_COMMAND()macro, we do not guarantee any particular order. Specifically, the order can change with implementation details.Testing procedure
The test should pass.
Issues/PRs references
#20958 has shown that changing implementation details of
SHELL_COMMAND()does affect the order of commands in thehelplist.