-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile.include: fix override headers from application #20744
Open
leandrolanzieri
wants to merge
4
commits into
RIOT-OS:master
Choose a base branch
from
leandrolanzieri:pr/makefile_include/include-app-headers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−57
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a63165a
Makefile.include: fix override headers from application
leandrolanzieri 1eb6667
tests/pkg/lwip: rename local header
leandrolanzieri 78413fe
tests/core/irq_cpp: remove irq.h override
leandrolanzieri 3120b0c
tests/net/ieee802154_hal: rename common.h
leandrolanzieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,18 +16,27 @@ | |
* @author Jens Wetterich <[email protected]> | ||
*/ | ||
|
||
#include <stdbool.h> | ||
|
||
/* prevent the inclusion of irq.h on irq.hpp */ | ||
#define IRQ_H | ||
unsigned irq_disable(void); | ||
unsigned irq_enable(void); | ||
bool irq_is_enabled(void); | ||
bool irq_is_in(void); | ||
void irq_restore(unsigned state); | ||
|
||
#define FFF_ARG_HISTORY_LEN 1u | ||
#define FFF_CALL_HISTORY_LEN 1u | ||
#include "cppunit.hpp" | ||
#include "fff.h" | ||
#include "irq.h" | ||
#include "irq.hpp" | ||
DEFINE_FFF_GLOBALS | ||
|
||
FAKE_VALUE_FUNC(unsigned, irq_disable) | ||
FAKE_VALUE_FUNC(unsigned, irq_enable) | ||
FAKE_VALUE_FUNC(int, irq_is_enabled) | ||
FAKE_VALUE_FUNC(int, irq_is_in) | ||
FAKE_VALUE_FUNC(bool, irq_is_enabled) | ||
FAKE_VALUE_FUNC(bool, irq_is_in) | ||
FAKE_VOID_FUNC(irq_restore, unsigned) | ||
|
||
class irq_suite : public riot::testing::test_suite { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,8 @@ | |
* | ||
* @author José I. Alamos <[email protected]> | ||
*/ | ||
#ifndef COMMON_H | ||
#define COMMON_H | ||
#ifndef TEST_COMMON_H | ||
#define TEST_COMMON_H | ||
|
||
#include "net/ieee802154/radio.h" | ||
#if IS_USED(MODULE_SOCKET_ZEP) | ||
|
@@ -60,5 +60,5 @@ void ieee802154_hal_test_init_devs(ieee802154_dev_cb_t cb, void *opaque); | |
} | ||
#endif | ||
|
||
#endif /* COMMON_H */ | ||
#endif /* TEST_COMMON_H */ | ||
/** @} */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,8 @@ | |
* | ||
* @author Martine Lenders <[email protected]> | ||
*/ | ||
#ifndef COMMON_H | ||
#define COMMON_H | ||
#ifndef CLI_H | ||
#define CLI_H | ||
|
||
#include <stdint.h> | ||
#include <sys/types.h> | ||
|
@@ -46,17 +46,6 @@ extern "C" { | |
* @} | ||
*/ | ||
|
||
/** | ||
* @brief Converts hex string to byte array. | ||
* | ||
* @param[out] out Resulting byte array | ||
* @param[in] in `\0` terminated string. Non-hex characters (all except 0-9, a-f, A-F) | ||
* will be ignored. | ||
* | ||
* @return Length of @p out. | ||
*/ | ||
size_t hex2ints(uint8_t *out, const char *in); | ||
|
||
#ifdef MODULE_SOCK_IP | ||
/** | ||
* @brief Raw IP shell command | ||
|
@@ -100,5 +89,5 @@ int udp_cmd(int argc, char **argv); | |
} | ||
#endif | ||
|
||
#endif /* COMMON_H */ | ||
#endif /* CLI_H */ | ||
/** @} */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Copyright (C) 2016 Martine Lenders <[email protected]> | ||
* | ||
* This file is subject to the terms and conditions of the GNU Lesser | ||
* General Public License v2.1. See the file LICENSE in the top level | ||
* directory for more details. | ||
*/ | ||
|
||
/** | ||
* @ingroup tests | ||
* @{ | ||
* | ||
* @file | ||
* @brief Utilities for tests/lwip/ | ||
* | ||
* @author Martine Lenders <[email protected]> | ||
*/ | ||
#ifndef UTILITIES_H | ||
#define UTILITIES_H | ||
|
||
#include <stdint.h> | ||
#include <sys/types.h> | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
/** | ||
* @brief Converts hex string to byte array. | ||
* | ||
* @param[out] out Resulting byte array | ||
* @param[in] in `\0` terminated string. Non-hex characters (all except 0-9, a-f, A-F) | ||
* will be ignored. | ||
* | ||
* @return Length of @p out. | ||
*/ | ||
size_t hex2ints(uint8_t *out, const char *in); | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif | ||
|
||
#endif /* UTILITIES_H */ | ||
/** @} */ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! I have falling into this pitfall numerous times when I needed to quickly test something, but never really traced it down but instead did a quick-and-dirty hack of the system header instead.
I'm glad that next time I need to quickly test something, I won't fall into that pitfall again ❤️