cpu/native: Move dependencies to Makefile.dep #14109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrolanzieri
added
Area: build system
leandrolanzieri
added
the
CI: ready for build
aabadie
approved these changes
May 20, 2020
There was a problem hiding this comment.
LGTM. The modules loaded are unchanged compared to master:
make -C examples/hello-world/ info-modules --no-print-directory
- this PR:
auto_init
board
core
core_init
core_msg
core_panic
cpu
native-drivers
periph
periph_common
periph_gpio
periph_init
periph_init_gpio
periph_init_pm
periph_init_uart
periph_pm
periph_uart
stdio_native
sys
- master:
auto_init
board
core
core_init
core_msg
core_panic
cpu
native-drivers
periph
periph_common
periph_gpio
periph_init
periph_init_gpio
periph_init_pm
periph_init_uart
periph_pm
periph_uart
stdio_native
sys
The list is exactly the same.
ACK
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This moves the
nativeCPU dependencies to itsMakefile.dep.Testing procedure
Green CI should be enough as
periph_uartis used always onstartup.c.Issues/PRs references
Part of #9913