Skip to content

board/mips-malta: include the cpu features instead of common cpu #10064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

board/mips-malta: include the cpu features instead of common cpu #10064

merged 1 commit into from
Oct 1, 2018

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Sep 27, 2018

Contribution description

board/mips-malta: include the cpu features instead of common cpu

This change was missed when the cpu 'mips32r2_generic' was separated
from 'mips32r2_common'. The target file already includes 'mips32r2_common'.

Testing procedure

The FEATURES_PROVIDED do not change between master and this PR for mips-malta:

make --no-print-directory -C examples/hello-world/ info-debug-variable-FEATURES_PROVIDED BOARD=mips-malta
periph_timer cpp periph_pm

Issues/PRs references

Inconsistency found while working on #9913

@cladmi
board/mips-malta: include the cpu features instead of common cpu
dc7726d 
This change was missed when the cpu 'mips32r2_generic' was separated
from 'mips32r2_common'. The target file already includes 'mips32r2_common'.
@cladmi cladmi added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Sep 27, 2018
@cladmi cladmi mentioned this pull request Sep 27, 2018
Open
22 tasks
smlng
smlng approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK, output of make info-build is also (mostly) equal, this PR only adds the Makefile.features from the generic folder

@cladmi cladmi mentioned this pull request Sep 28, 2018
Merged
@smlng smlng merged commit a9fcff3 into RIOT-OS:master Oct 1, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Oct 1, 2018

Thanks for reviewing.

@cladmi cladmi deleted the pr/board/mips-malta/cpu_features branch October 1, 2018 13:05
@jia200x jia200x added this to the Release 2018.10 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
3 participants
@cladmi @smlng @jia200x