Skip to content

Commit

Permalink
cpu/*/Makefile.feature: simple expansion for CPU_ARCH
Browse files Browse the repository at this point in the history
Simple expansion is recommended by official documentation [1] for a multitude
of reasons over recursive expansion, of which predictable behavior (and, thus,
maintainability of Makefiles) and performance are the biggest arguments.

[1]: https://www.gnu.org/software/make/manual/html_node/Flavors.html
  • Loading branch information
maribu committed Feb 16, 2021
1 parent b9a7c13 commit 501e346
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions cpu/arm7_common/Makefile.features
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CPU_ARCH = armv4t
CPU_CORE = arm7tdmi_s
CPU_ARCH := armv4t
CPU_CORE := arm7tdmi_s

FEATURES_PROVIDED += arch_32bit
FEATURES_PROVIDED += arch_arm
Expand Down
4 changes: 2 additions & 2 deletions cpu/esp32/Makefile.features
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CPU_ARCH = xtensa-lx6
CPU_FAM = esp32
CPU_ARCH := xtensa-lx6
CPU_FAM := esp32

# MCU defined features that are provided independent on board definitions

Expand Down
4 changes: 2 additions & 2 deletions cpu/esp8266/Makefile.features
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CPU_ARCH = xtensa-lx106
CPU_FAM = esp8266
CPU_ARCH := xtensa-lx106
CPU_FAM := esp8266


# MCU defined features that are provided independent on board definitions
Expand Down
2 changes: 1 addition & 1 deletion cpu/mips32r2_common/Makefile.features
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CPU_ARCH = mips32r2
CPU_ARCH := mips32r2

FEATURES_PROVIDED += arch_32bit
FEATURES_PROVIDED += arch_mips32r2
Expand Down
2 changes: 1 addition & 1 deletion cpu/riscv_common/Makefile.features
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CPU_ARCH = risc-v
CPU_ARCH := risc-v

FEATURES_PROVIDED += arch_32bit
FEATURES_PROVIDED += arch_riscv
Expand Down

0 comments on commit 501e346

Please sign in to comment.