Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transferID generation #147

Closed
wants to merge 1 commit into from

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Feb 15, 2024

Description

This PR corrects the creation of the transfer ID, using the audited version of commitments.

PS: I'm pointing to branch v0.11, because I noticed that you had already started the work of using the latest version of rgb-core.

@dr-orlovsky
Copy link
Member

Sorry, I am not getting why do we need these changes

@crisdut
Copy link
Member Author

crisdut commented Feb 15, 2024

Sorry, I am not getting why do we need these changes

Okay, firstly, I updated the version of rgb-core containing its latest fixes.

Then I noticed two problems:

  1. This line realize recursively calls of the Transfer::commit_encode method until the stackoverflow panics occurs.
  2. I create the wrapper type SecretSealSet to avoid occurs the error commit encoder can commit only to named types, similar to what happened here.

@dr-orlovsky
Copy link
Member

I see. It seems we need to refactor the whole way how this works. My variant is in 251cecf

@crisdut
Copy link
Member Author

crisdut commented Feb 15, 2024

I see. It seems we need to refactor the whole way how this works. My variant is in 251cecf

I will test now.

@crisdut crisdut closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants