Allow multiple messages to be scheduled with the same ID if the interval is set to 0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LandryNorris
commented
Sep 11, 2024
| m_sendQueue.push_back(detail::CANThreadSendQueueElement(msg, timeIntervalMs)); | ||
| } else { | ||
| // We don't want to replace elements with zero as the interval. Those should be guaranteed to be sent | ||
| detail::CANThreadSendQueueElement* existing = findFirstMatchingIdWithNonZeroInterval(msg.GetMessageId()); |
There was a problem hiding this comment.
After this change, calling with (data1, 0), then immediately calling with (data2, 5) will ensure that data1 is always sent once, then data2 is sent every 5 milliseconds.
There was a problem hiding this comment.
Also, more practically, calling with (data_i, 0) repeatedly will ensure all the data actually gets sent.
|
Nice find! |
ItsHarper
reviewed
Sep 11, 2024
| @@ -84,20 +84,41 @@ class DriverDeviceThread { | |||
| return nullptr; // If no matching element found | |||
| } | |||
|
|
|||
| detail::CANThreadSendQueueElement* findFirstMatchingIdWithNonZeroInterval(int targetId) { | |||
There was a problem hiding this comment.
It looks like findFirstMatchingId() can be deleted
ItsHarper
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current contract for the interval is as follows:
A caller that provides 0 multiple times can reasonably assume that every message is sent, but this was not the case previously. Only one message could be scheduled at a time with a given ID.