-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new generation of table manipulation tools #610
base: master
Are you sure you want to change the base?
Conversation
Do you know this tool? https://github.com/galaxyproject/tools-iuc/tree/main/tools/table_compute |
Yes I do ... but the tool is too complex in the form for what it can do and not very flexible. You can't choose specific columns etc. and overall I think it doesn't really cover the use cases. We actually adopted this schema from KNIME which provides very nice tools and operations to perform over tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I share the concerns of @bgruening and think that (in particular in case of the arithmetics and rename tool) it might be better to extend/improve existing tools.
@@ -0,0 +1,55 @@ | |||
<tool id="pandas_arithmetics" name="pandas arithmetics" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="20.01" license="MIT"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this tool I would think that an extension for table compute is more appropriate. The possibility to select specific columns / rows for arithmetic operations would definitely make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the multi select for the rows works, but it would probably have to provide both options
It could be an option to create 1-tool workflows for the tasks where we all the complexity of the the underlying tool gets hidden. |
@bernt-matthias yes, that is possible - though workflows don't support the column select input type properly, so you can't dynamically select the columns, which massively reduces user friendliness. |
Got it.
This is a point I totally support :) |
@bernt-matthias and @bgruening I would like to move this forward but I'm afraid there won't be a community consensus any time soon. I would recommend that we will pilot the tools locally, moving them to the toolshed but keeping them out of usegalaxy.* until we have some more experience with what is really needed and if the usability and everything is how we expected it. |
I asked @rmassei to have a look here. He has a KNIME history and could give us some feedback in this direction. I will also try to have another look on the tools. |
@bernt-matthias thanks a lot, that would be very helpful! |
Hi @bernt-matthias and @hechth!
By design, KNIME offers a broader selection of data wrangling tools, which might indeed feel more user-friendly. However, if a tool with similar functionality already exists in Galaxy (such as the table compute tool) and is likely already integrated into some workflows, wouldn't it be more practical to enhance the functionality of the existing tool and provide more user-friendly documentation in its help section? |
This PR introduces a set of new tabular file handling tools which are a bit more modern than what is available in the core galaxy tools.
The tools are based on pandas and/or scipy and all have a python CLI using argparse and should support parquet, csv, tsv and tabular files.
@bgruening and @bernt-matthias and @mvdbeek please give some feedback if you think this design works well or whether it should be done differently. I'm planning to add few more tools to this to cover many use-cases in various -omics disciplines.
Also @KristinaGomoryova please try the tools locally to see if this is roughly what you had in mind.
Also, please let me know whether you would see these tools rather in tools-iuc and if you have a better idea for naming this collection of tools, I'm open to suggestions.