Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated recetox-msfinder output and version #451

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

zargham-ahmad
Copy link
Collaborator

@zargham-ahmad zargham-ahmad commented Nov 29, 2023

This PR includes the following:

  • updated msfinder docker tag
  • updated tool output to either be an actual annotation or log file
  • added test and testdata

closes #434

@zargham-ahmad zargham-ahmad requested a review from hechth November 29, 2023 16:23
Comment on lines 2 to +5
<token name="@TOOL_VERSION@">v3.5.2</token>
<xml name="requirements">
<requirements>
<container type="docker">recetox/recetox-msfinder:v3.5.2-rcx0</container>
<container type="docker">recetox/recetox-msfinder:v3.5.2-rcx1</container>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the docker image tag -rcx1 into the tool version was not legal if I remember it correctly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@hechth hechth merged commit ad60bf8 into RECETOX:master Dec 1, 2023
10 checks passed
@zargham-ahmad zargham-ahmad deleted the issue434 branch January 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update recetox-msfinder to version that writes log files
2 participants