Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes coordination complexes compounds #441

Merged
merged 24 commits into from
Nov 27, 2023
Merged

Conversation

wverastegui
Copy link
Contributor

The tool removes only coordination complexes compounds from a list of smiles. The input files can be csv, InChI and SMILEs formats. The tool return same input formats as output file formats.

Linked issue: #430

@wverastegui wverastegui requested a review from hechth November 22, 2023 09:19
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes are needed before this can be merged - please see the comments and ask if anything is unclear :)

tools/rem_complex/.shed.yml Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.xml Outdated Show resolved Hide resolved
tools/rem_complex/macros.xml Outdated Show resolved Hide resolved
tools/rem_complex/test-data/input.csv Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.py Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.py Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.py Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.xml Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.py Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.py Outdated Show resolved Hide resolved
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the testdata in inchi and smiles formats represent the same compounds?

tools/rem_complex/.shed.yml Outdated Show resolved Hide resolved
tools/rem_complex/rem_complex.xml Outdated Show resolved Hide resolved
@hechth hechth self-requested a review November 27, 2023 08:21
@hechth hechth merged commit 833f767 into master Nov 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a tool which enables filtering coordination complexes and mixtures from a list of SMILES
2 participants