Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defined namespace warnings #2964

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

ashleysommer
Copy link
Contributor

Current docs-generation tests are polluted by lots of warnings that occur when Sphinx tries to read various parts of DefinedNamespace.

Current docs-generation tests are polluted by lots of warnings that occur when Sphinx tries to read various parts of DefinedNamespace.
@ashleysommer ashleysommer marked this pull request as ready for review November 1, 2024 02:52
@ashleysommer ashleysommer merged commit 4be4216 into main Nov 1, 2024
22 checks passed
@ashleysommer ashleysommer deleted the defined_namespace_warnings branch November 1, 2024 04:22
@coveralls
Copy link

Coverage Status

coverage: 90.271% (-0.004%) from 90.275%
when pulling 84ccd43 on defined_namespace_warnings
into d119ebe on main.

ashleysommer added a commit that referenced this pull request Nov 1, 2024
* Fix defined namespace warnings

Current docs-generation tests are polluted by lots of warnings that occur when Sphinx tries to read various parts of DefinedNamespace.

* Fix tests that no longer need incorrect exceptions handled.

* fix black formatting in test file

* Undo typing changes, so this works on current pre-3.9 branch

* better handling for any/all double-underscore properties

* Don't include __slots__ in dir().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants