Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Collection from adding 'rdf:nil rdf:rest rdf:nil.' triples #2818

Merged
merged 10 commits into from
Jul 30, 2024

Commits on Jul 5, 2024

  1. fix: Prevent Collection from add 'rdf:nil rdf:rest rdf:nil.' triples

    Creating 'Collection(graph, RDF.nil)' used to add a 'rdf:nil rdf:rest rdf:nil.'
    triple to the graph, which turned the empty list into an infinite list.
    
    This was a side-effect of unconditionally appending 'seq' to the collection,
    which is not possible when the collection is 'nil' without ill side-effects.
    
    This commit makes the append conditional; and also checks the collection
    is non-empty in case the user explicitly tries to add item to the empty list.
    progval committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    fc02817 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    3cece74 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    99077f3 View commit details
    Browse the repository at this point in the history
  2. Move emptiness check out of _end()

    This will allow using _end() in other methods that would not need to append
    progval committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    548be94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ae46a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Also prevent insertion at the end of finalized lists

    Co-authored-by: Ashley Sommer <[email protected]>
    progval and ashleysommer authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ea81da5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    c48eb78 View commit details
    Browse the repository at this point in the history
  2. Also prevent .append() on finalized lists

    Co-authored-by: Ashley Sommer <[email protected]>
    progval and ashleysommer authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    859848c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8be2cb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    6e65136 View commit details
    Browse the repository at this point in the history