-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Collection from adding 'rdf:nil rdf:rest rdf:nil.' triples #2818
Merged
Commits on Jul 5, 2024
-
fix: Prevent Collection from add 'rdf:nil rdf:rest rdf:nil.' triples
Creating 'Collection(graph, RDF.nil)' used to add a 'rdf:nil rdf:rest rdf:nil.' triple to the graph, which turned the empty list into an infinite list. This was a side-effect of unconditionally appending 'seq' to the collection, which is not possible when the collection is 'nil' without ill side-effects. This commit makes the append conditional; and also checks the collection is non-empty in case the user explicitly tries to add item to the empty list.
Configuration menu - View commit details
-
Copy full SHA for fc02817 - Browse repository at this point
Copy the full SHA fc02817View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3cece74 - Browse repository at this point
Copy the full SHA 3cece74View commit details
Commits on Jul 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 99077f3 - Browse repository at this point
Copy the full SHA 99077f3View commit details -
Move emptiness check out of _end()
This will allow using _end() in other methods that would not need to append
Configuration menu - View commit details
-
Copy full SHA for 548be94 - Browse repository at this point
Copy the full SHA 548be94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ae46a4 - Browse repository at this point
Copy the full SHA 1ae46a4View commit details
Commits on Jul 25, 2024
-
Also prevent insertion at the end of finalized lists
Co-authored-by: Ashley Sommer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ea81da5 - Browse repository at this point
Copy the full SHA ea81da5View commit details
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c48eb78 - Browse repository at this point
Copy the full SHA c48eb78View commit details -
Also prevent .append() on finalized lists
Co-authored-by: Ashley Sommer <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 859848c - Browse repository at this point
Copy the full SHA 859848cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8be2cb2 - Browse repository at this point
Copy the full SHA 8be2cb2View commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e65136 - Browse repository at this point
Copy the full SHA 6e65136View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.