Release v0.5.2 #150

Bachibouzouk · 2024-06-03T20:20:53Z

The changelog should be filled here
The version number should be bumped
Test release should be performed with release candidates

try fix the issue with test-pypi

solve the similar issue of test-pypi with the workflow in the publish-pypi workflow

…ease-issue-1 Update python-pypi-test.yml

Skip appliance if func_time==0 or rand_time==0

- in Appliance -> .update_daily_use: - duration of switch-on event is corrected to be only as long as duty cylce - corrected duration of switch-on event is returned - in Appliance -> .generate_load_profile - calculation of total time of operation is performed using corrected duration of switch-on event

- Introduce current_duty_cycle_id as attribute of Appliance to keep track of the current duty cycle and avoid re-evaluating which duty-cycle is concerned by a switch on event - Change x in range(a,b) to a <= x < b as the latter is about 5 times faster 243 ns vs 51.4 ns - Remove direct mention of specific issue in the comments

As now indexes are not updated by update daily_use but by rand_switch_on_window, it is less risky for backward compatibility to update the total time before entering the loop

When this parameter is set to False (default) te behavior should be the same as previously, i.e. continuous duty cyles during the entire switch on event (can contain several duty cycles). Only when set to True would the switch on event be limited to the duration of the duty cycle in order to better model productive use of appliances (mill, welder)

It needs to be run from the root of the repository

Fix/duty cycle repetition for productive use

Fix/empty peak time range

to ensure the Back-compatibility with legacy code, the Appliance method of User class is present. However the method is not further maintained since the nex-gen version of the sofware. To warn the users to move towards the new method, a DeprecationWarning is added.

FLomb · 2024-06-05T11:33:51Z

Hi,

Some issues I detected:

The conversion of .py files into .xlsx files is not working again. The code looks for modules instead of files, even though we had already fixed this bug before. Apparently, it was reintroduced at some point through other means because the lines that caused the error in the past are not there anymore.
The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.
In the docs, in 'RAMP introduction/contributing', we provide a link to the 'Contribution guidelines'. However, the link is broken - not sure if this is the case only because I am looking at the docs generated within the PR.

Bachibouzouk · 2024-06-05T11:41:52Z

The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.

Test_run is only supposed to be runnable if you are developping and installed ramp locally with pip install -e .

Bachibouzouk · 2024-06-05T11:53:39Z

In the docs, in 'RAMP introduction/contributing', we provide a link to the 'Contribution guidelines'. However, the link is broken - not sure if this is the case only because I am looking at the docs generated within the PR.

This one at least works locally, it is most certainly a problem of file path, or maybe we need to push the copy of the Contribute.md file as well (locally the file is copied and included in the index directly as wagtail allows a mix and match of .rst and .md files)

FLomb · 2024-06-05T12:34:04Z

The qualitative testing functionality is not working due to some broken paths in what test_run.py tries to do.

Test_run is only supposed to be runnable if you are developping and installed ramp locally with pip install -e .

I've also tried using a developer version installed locally, but it still doesn't work. The BASE_PATH that it uses to create the TEST_OUTPUT_PATH gets messed up and points to a completely wrong location. I have pasted below the error message to give you an idea:

line 97, in <module>
    for file in os.listdir(TEST_OUTPUT_PATH):
FileNotFoundError: [Errno 2] No such file or directory: '/home/fl/miniconda3/envs/ramp_test_2/lib/python3.10/site-packages/rampdemand-0.5.2-py3.10.egg/ramp/test/results'

Previously the mean of the index range was computed and see if it was falling within a duty cycle. This method compare the boundaries of the range with the one of each duty cycle to know if there is an intersection. If there is one, the duty cycle is chosen. Note: this method does not take into account the case where the indexes range spans accross more than one duty cycle.

Fix duty cycle selection

Small fixes before the release

With some pre-commit linting fixes on previous releases

So that twine check dist/* does not output errors. Pre-commit removed trailing spaces in the file as well

FLomb

I've tested the PR, and it works smoothly; thanks for the work, @Bachibouzouk

mohammadamint and others added 30 commits March 18, 2024 10:57

Update python-pypi-test.yml

3cee920

try fix the issue with test-pypi

Update python-publish-pypi.yml

f142bfc

solve the similar issue of test-pypi with the workflow in the publish-pypi workflow

Merge pull request #117 from RAMP-project/96-solving-the-testpypi-rel…

0c0f51e

…ease-issue-1 Update python-pypi-test.yml

Fix issue 114. Skip app if func_time or rand_time==0

76e5342

Add warning if appliance with func_time=0 is defined

1f87cc0

Add tests and fix faulty func_time warning

d9fcb0a

Formatted code with black.

8d5d504

Remove comments about the issue number

3d864d2

Check for raising of warning within the test function

0c65148

Merge pull request #116 from JW-Kraft/fix/func_time_zero_error

a0346dd

Skip appliance if func_time==0 or rand_time==0

Implemented unit test for fix of issue 78 (#78)

df3c22f

Formatted code with black.

f92054d

Compute total time before while loop

293242a

As now indexes are not updated by update daily_use but by rand_switch_on_window, it is less risky for backward compatibility to update the total time before entering the loop

Keep assignement to duty cycle 3 similar to past code

1355a16

Fix the duty cycle test

2e162de

Make continuous_duty_cycle an Appliance attribute

d5029ea

Update example notebook for use of non continuous duty cycle

21f6d40

Add continuous_use_duty_cycle to appliance attributes

35428a4

Update changelog

3d34976

Fix old comparative tests script

3819467

It needs to be run from the root of the repository

Prevent load from excel to throw error if new attribute not present

5b42bdc

Remove unused line

0564791

Merge pull request #111 from JW-Kraft/fix/duty-cycle-repetition

03cb5cb

Fix/duty cycle repetition for productive use

Round rand_peak_enlarge to be at least 1 to avoid empty peak_time_range

c5937c9

Merge pull request #132 from RAMP-project/fix/empty_peak_time_range

96c987d

Fix/empty peak time range

adding the paper files for JOSS

57b13ee

Bachibouzouk and others added 19 commits June 5, 2024 15:36

Let the file to convert being added to system path also on posix

d8f3c35

Attemp to fix the online documentation

0c87d2c

fix path issues in test_run.py

0922874

Set a user's appliance name by default if empty

522b436

Add appliances name to example files

ff026c9

Reselect a switch on even if falling outside duty cycle windows

14f1d61

Fix fridge duty cycle

4b4fce7

Extend duty_cycle window to upper bound

510c164

Fix failing tests

2ea6532

Merge pull request #153 from RAMP-project/fix/duty_cycle_selection

fce9fc9

Fix duty cycle selection

Minor docstring improvements

75cb11d

Remove use of matplotlib join method in test_use

f25fbf4

Fix contribution link

0fbb021

Remove contributing.md from docs/source

37c9d21

Merge pull request #152 from RAMP-project/fix/ramp_convert

077ddbe

Small fixes before the release

Update changelog

0ec1e67

With some pre-commit linting fixes on previous releases

Bump version number

1e4cc7e

Fix README formatting

b31aaf8

So that twine check dist/* does not output errors. Pre-commit removed trailing spaces in the file as well

Bachibouzouk force-pushed the release/0.5.2 branch from df93fb4 to b31aaf8 Compare June 7, 2024 06:50

Allow all python version below 3.12

9ddd6a4

Bachibouzouk marked this pull request as ready for review June 7, 2024 13:09

Bachibouzouk requested a review from FLomb June 7, 2024 13:10

FLomb approved these changes Jun 7, 2024

View reviewed changes

Bachibouzouk merged commit 13e0cee into main Jun 7, 2024
3 checks passed

Bachibouzouk deleted the release/0.5.2 branch June 7, 2024 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.5.2 #150

Release v0.5.2 #150

Bachibouzouk commented Jun 3, 2024 •

edited

Loading

FLomb commented Jun 5, 2024

Bachibouzouk commented Jun 5, 2024

Bachibouzouk commented Jun 5, 2024

FLomb commented Jun 5, 2024

FLomb left a comment

Release v0.5.2 #150

Release v0.5.2 #150

Conversation

Bachibouzouk commented Jun 3, 2024 • edited Loading

FLomb commented Jun 5, 2024

Bachibouzouk commented Jun 5, 2024

Bachibouzouk commented Jun 5, 2024

FLomb commented Jun 5, 2024

FLomb left a comment

Choose a reason for hiding this comment

Bachibouzouk commented Jun 3, 2024 •

edited

Loading