Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial suggested changes to JOSS paper #148

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Editorial suggested changes to JOSS paper #148

merged 1 commit into from
Jun 3, 2024

Conversation

AdamRJensen
Copy link
Contributor

No description provided.

@AdamRJensen AdamRJensen mentioned this pull request Jun 2, 2024
Closed
FLomb
FLomb approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@FLomb FLomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposed changes. They all look sensible to me, so I am happy to approve this PR.

@Bachibouzouk Bachibouzouk merged commit 874a97c into RAMP-project:joss-paper Jun 3, 2024
1 of 2 checks passed
@Bachibouzouk
Copy link
Collaborator

The tests were not passing because of the token for Coveralls, as the PR was initiated from a fork. Because only the text of the paper was changed it was not unsafe to merge although the tests did not pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FLomb FLomb FLomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamRJensen @Bachibouzouk @FLomb