Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/expand manuscript #145

Merged
merged 4 commits into from
May 30, 2024
Merged

Review/expand manuscript #145

merged 4 commits into from
May 30, 2024

Conversation

FLomb
Copy link
Contributor

@FLomb FLomb commented May 30, 2024

With this PR we address comments by JOSS reviewers about:

  • Expanding the literature and the sofwtare's positioning with respect to existing alternatives
  • Expanding on the customisation options

Additionally, we added two more authors, as discussed with JOSS's reviewers

@FLomb FLomb requested a review from Bachibouzouk May 30, 2024 11:31
And fix trailing spaces (pre-commit hooks)
Copy link
Collaborator

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the changes good, the only thing I spotted were misformatted citations within a paragraph and I pushed a commit for it

@Bachibouzouk Bachibouzouk merged commit d62bcd6 into joss-paper May 30, 2024
3 checks passed
@Bachibouzouk Bachibouzouk deleted the review/expand-manuscript branch June 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants