Remove usage of deprecated User.Appliance class #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bachibouzouk
force-pushed
the
review/deprecated_appliance
branch
from
b9bad92
to
e2f87ea
Compare
Bachibouzouk
force-pushed
the
review/deprecated_appliance
branch
from
e2f87ea
to
7bea430
Compare
FLomb
approved these changes
May 14, 2024
There was a problem hiding this comment.
Hi @Bachibouzouk,
Fantastic work; this was long overdue and extremely needed. This is also a quick and easy approval because it's just a matter of text adaptations.
Do this only for the first occurence as there are many appliances and users in examples 1 and 3
Bachibouzouk
force-pushed
the
review/deprecated_appliance
branch
from
7bea430
to
505e4aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this usage is now deprecated our example files should not contain it.