-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code to reproduce JOSS figure #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this file ended up in the commit; I shouldn't have changed anything there and for some reason git diff
does not return any difference between my commit and the joss-paper
branch for this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the image generated must be slightly different, this is the only line highlighted (once you commited git diff
will not show the diff anymore), you can do git diff HEAD~1
to get the diff of the last commit.
You can use
To generate a figure similar using the new plotting capabilities |
@Bachibouzouk Thanks :-). Sorry for my delay in replying! |
Ok, thanks for your guidance. I've updated the figure accordingly. What we get is an almost identical result, except for colours. I reckon there's no way to change the colours of the |
You can get the plotted lines from the axis handle |
Thanks for the tip! I've updated the code with custom colours. Now, the figure looks as expected; I should update the paper with it because it's still marginally different. |
1902311
to
cccef12
Compare
e0a508d
to
2e868f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FLomb this looks neat
I added a seed to the UseCase so the figure is reproducable
JOSS's reviewers asked for the inclusion of the code to reproduce the illustrative Figure we have in the paper (see: openjournals/joss-reviews#6418 (comment)). This PR addresses this.
However, the PR is currently based on the old plotting functionality with some customisation. As discussed during RAMP's development meetings, it'd be better to produce a similar Figure with the newest plotting functionality. I tried doing so via the
shadow
plot functionality, but I struggled to customise it to the degree needed. For example, I did not manage to pass kwargs related to the ax object or to the colours of the lines. Perhaps @mohammadamint may know how to do it. If not possible, we may as well stick to this custom code.