Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage and coveralls to test requirements #136

Merged
merged 6 commits into from
May 14, 2024

Conversation

Bachibouzouk
Copy link
Collaborator

@Bachibouzouk Bachibouzouk commented Apr 29, 2024

Reviewer comment

3. What is the test coverage of the project? Since there are not that many, it would be good to check that minimum coverage is realised.

Need to follow the steps : https://coveralls.io/github/RAMP-project/RAMP#step1

@Bachibouzouk Bachibouzouk self-assigned this Apr 29, 2024
@Bachibouzouk Bachibouzouk marked this pull request as ready for review May 8, 2024 20:37
@Bachibouzouk
Copy link
Collaborator Author

I needed to go into Settings --> Actions --> general and select Allow RAMP-project, and select non-RAMP-project, actions and reusable workflows plus tick the Allow actions created by GitHub option

@Bachibouzouk Bachibouzouk force-pushed the feature/enable-coveralls branch 3 times, most recently from 187cc8b to e45d18c Compare May 8, 2024 21:32
@Bachibouzouk
Copy link
Collaborator Author

Now the coverage status can be viewed here: https://coveralls.io/github/RAMP-project/RAMP

@Bachibouzouk
Copy link
Collaborator Author

@FLomb, @mohammadamint once you approve this PR we can merge it an benefit from CI for tests, linting as well as coverage

Copy link
Contributor

@FLomb FLomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks in good order. Thanks for taking care of this, @Bachibouzouk !

@FLomb FLomb merged commit 6c1cc8c into joss-paper May 14, 2024
3 checks passed
@Bachibouzouk Bachibouzouk deleted the feature/enable-coveralls branch May 14, 2024 12:31
@Bachibouzouk Bachibouzouk restored the feature/enable-coveralls branch May 14, 2024 13:50
@Bachibouzouk Bachibouzouk deleted the feature/enable-coveralls branch June 24, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants