Skip appliance if func_time==0 or rand_time==0

[JW-Kraft]

Fix #114

Implemented fix as proposed in issue 114:

• add rand_time!=0 as condition in the while loop of function Appliance.generate_load_profile. This way, appliances are skipped when the rand_time is calculated to be 0, which can happen when time_fraction_random_variability is set to 1.

One small addition:

• first check if self.func_time==0 (line 1803) -> if so, appliance is skipped directly, without calculating rand_time. Otherwise, Appliance.rand_total_time_of_use can throw error.

[Bachibouzouk]

To be able to checkout locally @JW-Kraft branch I did

git fetch origin pull/116/head:<whichever name I want to have locally>

We only have read acces unless @JW-Kraft grant us write access like described in the docs

[Bachibouzouk]

normally you could simply create an appliance without user or usecase and call generate_load_profile

[Bachibouzouk]

Thanks for submitting a fix for this @JW-Kraft !

[Bachibouzouk]

@FLomb - are you ok with merging without having the testpypi test being able to run? (the problem there is credentials of test-pypi)

[FLomb]

@FLomb - are you ok with merging without having the testpypi test being able to run? (the problem there is credentials of test-pypi)

I'm not following, why do we have credentials issues with test-pypi?

[mohammadamint]

@FLomb - are you ok with merging without having the testpypi test being able to run? (the problem there is credentials of test-pypi)

@Bachibouzouk the issue is very similar to https://github.com/orgs/community/discussions/57621

[Bachibouzouk]

@FLomb - are you ok with merging without having the testpypi test being able to run? (the problem there is credentials of test-pypi)

@Bachibouzouk the issue is very similar to https://github.com/orgs/community/discussions/57621

@mohammadamint - can it be that because the PR is based form a fork, the permissions are not sufficient to run test-pypi deploy test? Because I did merge your fix and update the PR

[mohammadamint]

@FLomb - are you ok with merging without having the testpypi test being able to run? (the problem there is credentials of test-pypi)

@Bachibouzouk the issue is very similar to https://github.com/orgs/community/discussions/57621

@mohammadamint - can it be that because the PR is based form a fork, the permissions are not sufficient to run test-pypi deploy test? Because I did merge your fix and update the PR

This seems to be the issue. A solution could be to instead of triggering the workflow on pull requests, trigger it on tag or release creation events. Do you see any problem with this solution @Bachibouzouk ?

[Bachibouzouk]

Do you see any problem with this solution @Bachibouzouk ?

No I think what you propose make sense

[mohammadamint]

Do you see any problem with this solution @Bachibouzouk ?

No I think what you propose make sense

There is one problem, and that is that the workflow wont be triggered on PR but on push event. I would ignore the issue for now, and proceed with this PR, if urgent, so meanwhile I can seek for a better solution.

[FLomb]

Do you see any problem with this solution @Bachibouzouk ?

No I think what you propose make sense

There is one problem, and that is that the workflow wont be triggered on PR but on push event. I would ignore the issue for now, and proceed with this PR, if urgent, so meanwhile I can seek for a better solution.

It looks like all tests pass now; does this mean you have implemented a solution to the test PyPi issue?

[Bachibouzouk]

It looks like all tests pass now; does this mean you have implemented a solution to the test PyPi issue?

They all passed because their number reduced from 3 to 2 tests, after the changes introduced by @mohammadamint and approved by me. I am not sure I got why it did not work, does it only work when I push to this PR now?

[mohammadamint]

It looks like all tests pass now; does this mean you have implemented a solution to the test PyPi issue?

They all passed because their number reduced from 3 to 2 tests, after the changes introduced by @mohammadamint and approved by me. I am not sure I got why it did not work, does it only work when I push to this PR now?

indeed. I would however, switch back to previous version after finalizing this PR, until I can find a better solution, hopefully by the end of the week!