Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow charts to have customized liveness and readiness probes #97

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

keyvaann
Copy link
Collaborator

Allow custom application images to define their own health checks instead of using the hard coded one.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering a bit about the customLivenessProbe syntax, is this something that Bitnami also does? It's not blocking though, so go ahead and merge.

@@ -93,6 +93,41 @@ extraEnvVars: []
# - name: BEARER_AUTH
# value: true

# -- Custom livenessProbe that overrides the default one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to clarify that all livenessProbe values are disregarded if this custom livenessProbe is defined. Alternatively, just add the httpGet command to livenessProbe and users can override it, so the yaml is just copied to the deployment?

@keyvaann
Copy link
Collaborator Author

The syntax is copied from Bitnami, since I'd like to be compatible with their syntax and rather not change things unless necessary.
The syntax is a simple toYaml statement custom probe is specified: livenessProbe: {{- .Values.customLivenessProbe | toYaml | nindent 12 }}
Each service uses a different way to do the healthcheck, most use exec, some httpGet and some tcpSocket, adding only httpGet wouldn't fit all of them.

@keyvaann keyvaann merged commit 4bc3be5 into main Sep 19, 2023
4 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the custom-probes branch February 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants