Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radar-appserver] Add SMTP server configuration to send notifications via email #214

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

pvannierop
Copy link
Collaborator

@pvannierop pvannierop commented Jul 5, 2024

Description of the change

This PR will pass SMTP connection credentials to the Appserver application. When value smtp.enabled=true, Appserver will send notifications via email alongside push notifications.

Note

This feature depends on a new version of Appserver that is not yet available. The version bump will happen when new app version exists.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

Copy link

github-actions bot commented Jul 5, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@pvannierop pvannierop requested a review from keyvaann July 5, 2024 11:50
@pvannierop pvannierop self-assigned this Jul 5, 2024
Appserver will start to send notifications via email when SMTP is enabled.
@pvannierop pvannierop force-pushed the appserver-email-notifications branch from e432733 to a2ff0b9 Compare July 5, 2024 11:52
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop force-pushed the appserver-email-notifications branch from 48525a9 to 819963f Compare July 9, 2024 06:19
@pvannierop pvannierop merged commit 055474e into main Jul 12, 2024
4 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the appserver-email-notifications branch August 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants