Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-dashboard-backend] Several fixes to chart #203

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

pvannierop
Copy link
Collaborator

Main changes:

  • TLS secret name was renamed to match nomenclature of other secrets
  • Added JDBC properties for the service needed to comply with JDBC-connector generated database table
  • Fixed default MP scopes needed for data-dashboard-backend to work

@pvannierop pvannierop requested a review from keyvaann June 14, 2024 12:06
@pvannierop pvannierop self-assigned this Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@@ -33,7 +33,6 @@ API for data in the data dashboard
| replicaCount | int | `1` | Number of replicas to deploy |
| image.repository | string | `"radarbase/radar-data-dashboard-backend"` | docker image repository |
| image.pullPolicy | string | `"Always"` | image pull policy |
| image.tag | string | `nil` | Overrides the image tag whose default is the chart appVersion. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is being removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to regenerate the docs. Entry is back now.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop force-pushed the data-dashboard-backend-fixes branch 2 times, most recently from 5376e12 to 782893a Compare June 21, 2024 07:04
@pvannierop pvannierop force-pushed the data-dashboard-backend-fixes branch from 782893a to e6338ef Compare June 21, 2024 07:06
@keyvaann keyvaann merged commit d955250 into main Jun 21, 2024
4 checks passed
@keyvaann keyvaann deleted the data-dashboard-backend-fixes branch June 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants