Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog-server to appversion 0.8.8 #125

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

Bdegraaf1234
Copy link
Member

@Bdegraaf1234 Bdegraaf1234 commented Apr 30, 2024

Description of the change

Update the catalog server chart to appversion 0.8.8

Benefits

Security updates for the catalog server

Possible drawbacks

None

Applicable issues

NA

Additional information

The hotfix was applied due to an issue with accessing the confluent-cloud platform

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 self-assigned this Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not having -hotfix in version names and keep things numerical so in future we can use automated tools for version management

@Bdegraaf1234
Copy link
Member Author

So should we make another release from the same code? so that 0.8.7-hotfix==0.8.8?

@keyvaann
Copy link
Collaborator

keyvaann commented May 1, 2024

So should we make another release from the same code? so that 0.8.7-hotfix==0.8.8?

Yes indeed. We (try to) follow Semantic Versioning in radar-base
https://semver.org

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bdegraaf1234 Bdegraaf1234 changed the title catalog-server to appversion 0.8.7 catalog-server to appversion 0.8.8 May 2, 2024
@Bdegraaf1234 Bdegraaf1234 merged commit 8f61c70 into main May 2, 2024
4 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the update-catalog-server branch May 2, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants