Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More commit hooks #42

Merged
merged 1 commit into from
Jan 10, 2025
Merged

More commit hooks #42

merged 1 commit into from
Jan 10, 2025

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Jan 9, 2025

These are more utility hooks to prevent mistakes and standardize commits.

@keyvaann keyvaann requested a review from baixiac January 9, 2025 09:57
Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Just a hypothetical question: judging by appearance typos and codespell seem to target the same problem. Is it guaranteed they will work complementary to each other or could they one day step on each other's toes?

@keyvaann
Copy link
Collaborator Author

keyvaann commented Jan 9, 2025

I have noticed that they sometimes find different misspellings, in case of issues in this PR both of them were reporting same typos.

Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Let's experiment with both a bit longer. Ideally, one of those will be necessary.

@keyvaann
Copy link
Collaborator Author

I think they have different focus than each other and complement each other.

@keyvaann keyvaann merged commit b398307 into main Jan 10, 2025
1 check passed
@keyvaann keyvaann deleted the more-commit-hooks branch January 10, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants