Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialise plugins before running TF validate in make prepare #36

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Initialise plugins before running TF validate in make prepare #36

merged 1 commit into from
Dec 30, 2024

Conversation

baixiac
Copy link
Member

@baixiac baixiac commented Dec 19, 2024

Atm if required plugins are missing or corrupted, make prepare will fail on TF validate hence this PR.

@baixiac baixiac requested a review from keyvaann December 19, 2024 15:00
keyvaann
keyvaann approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baixiac baixiac merged commit 6b6914d into main Dec 30, 2024
2 checks passed
@baixiac baixiac deleted the make-prepare-fix branch December 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baixiac @keyvaann