TTT10 reader #912
Merged
TTT10 reader #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhiteheadyork
force-pushed
the
ttt10
branch
2 times, most recently
from
3047f19 to
7660e0f
Compare
jose-luis-rs
requested changes
Dec 20, 2023
| // ----- Default constructor ------------------------------------------- | ||
| R3BTTTXMappedData::R3BTTTXMappedData() | ||
| : fDetID(0) | ||
| , fChannelID(0) |
There was a problem hiding this comment.
fChannelID should be fStripID because this is for a silicon detector with 32 strips, right?
| // ----- Standard constructor ------------------------------------------ | ||
| R3BTTTXMappedData::R3BTTTXMappedData(UInt_t DetID, UInt_t ChannelID, Int_t time, Int_t energy, Bool_t pu, Bool_t ov) | ||
| : fDetID(DetID) | ||
| , fChannelID(ChannelID) |
|
|
||
| /** Constructor with arguments | ||
| *@param DetID Detector ID attention 0-based ! | ||
| *@param ChannelID Channel ID attention 0-based ! |
There was a problem hiding this comment.
StripID in 1-based instead of 0-based
|
|
||
| /** Accessors **/ | ||
| inline const UInt_t& GetDetID() const { return fDetID; } | ||
| inline const UInt_t& GetChannelID() const { return fChannelID; } |
|
|
||
| /** Modifiers **/ | ||
| void SetDetID(UInt_t id) { fDetID = id; }; | ||
| void SetChannelID(UInt_t id) { fChannelID = id; }; |
|
|
||
| protected: | ||
| UInt_t fDetID; | ||
| UInt_t fChannelID; |
|
Hi @jose-luis-rs, the changes have been made and should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Mapped level and reader for TTT10.
Mention any issue this PR is resolved or is related to.
Checklist:
devbranch