fix a small bug at mp_wargame intro, will crash when player disconnect at a special freame #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translated using Weblate (Portuguese) Currently translated at 100.0% (311 of 311 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/pt/ Co-authored-by: William Miller <[email protected]>
* Translated using Weblate (Japanese) Currently translated at 96.1% (299 of 311 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (311 of 311 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/ja/ --------- Co-authored-by: IROHASTUDIO <[email protected]>
This is done so mods using keyvalues folders to add custom fonts to the game don't revert the changes done by Northstar
Previously, the verified mods manifesto was fetched on game start without checking if the verified mod feature is enabled Squirrel-side; with this, the manifesto is only fetched when the user wants to download a mod (meaning they enabled the feature beforehand).
Adds a function that allows the client to join a server from a `ServerInfo` struct. This also changes the server browser to use this function.
…orthstar#796) See pull request description for highly detailed changelog.
Translated using Weblate (Russian) Currently translated at 94.8% (297 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/ru/ Co-authored-by: WofWca <[email protected]>
Translated using Weblate (Portuguese) Currently translated at 100.0% (313 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/pt/ Co-authored-by: William Miller <[email protected]>
This parameter is a leftover of a previous refactor, and isn't used anywhere in the function.
Revert "Add a generic "JoinServer" function (R2Northstar#693)" as it causes issues with MAD due to duplicated server join logic as discussed on Discord This reverts commit e4b3cc7.
so that labels can easily be updated if need be
Translated using Weblate (French) Currently translated at 100.0% (313 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/fr/ Co-authored-by: Rémy Raes <[email protected]>
Translated using Weblate (Italian) Currently translated at 99.6% (312 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/it/ Co-authored-by: Nostromo <[email protected]>
Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (313 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/zh_Hant/ Co-authored-by: RainTrap341 <[email protected]>
Adds an `IsAlive()` check to temporarily handle a rare crash
Adds file for Polish translations as well as the translations themselves.
Translated using Weblate (Polish) Currently translated at 100.0% (313 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/pl/ Co-authored-by: eve <[email protected]>
…R2Northstar#846) The quotation marks caused file parsing to end early and break
from v3 which is being deprecated
Translated using Weblate (Polish) Currently translated at 100.0% (313 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/pl/ Co-authored-by: p0358 <[email protected]>
As they are supposed to be disabled unless joining a server that requires that mod.
Translated using Weblate (German) Currently translated at 99.0% (310 of 313 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/de/ Co-authored-by: Maya <[email protected]>
Co-authored-by: Zanieon <[email protected]>
in an effort to have all related functions close to each other
in an effort to have all related functions close to each other Part of the refactor in R2Northstar#830
as part of the refactoring effort in R2Northstar#830
as part of the refactoring effort in R2Northstar#830
as part of the refactoring effort in R2Northstar#830
as part of the refactoring effort in R2Northstar#830
…tar#854) Co-authored-by: Zanieon <[email protected]>
to prevent potential script crash Co-authored-by: Zanieon <[email protected]>
…thstar#852) This needs to be threaded as there's a `waitthread` further below on that function, which will cause an error if not threaded.
|
欸怎么发错地方了，我是铸币 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[15:02:59] [NORTHSTAR] [info] Player Elyearend disconnected: "Disconnect by user."
[15:02:59] [NORTHSTAR] [info] Player Elyearend disconnected: "Disconnect by user."
[15:02:59] [NORTHSTAR] [warn] attempted to write pdata of size 0!
[15:02:59] [SCRIPT SV] [info] SCRIPT ERROR: [SERVER] Attempted to call GetPersistentVar on invalid entity
[15:02:59] [SCRIPT SV] [info] -> return expect string ( player.GetPersistentVar( "factionChoice" ) )
[15:02:59] [SCRIPT SV] [info]
CALLSTACK
*FUNCTION [GetFactionChoice()] conversation/sh_faction_dialogue.gnut line [136]
*FUNCTION [ConvertPlayerFactionToIMCOrMilitiaTeam()] conversation/sh_faction_dialogue.gnut line [188]
*FUNCTION [PlayerWatchesWargamesIntro()] mp/levels/mp_wargames.nut line [260]
[15:02:59] [SCRIPT SV] [info] LOCALS
[player] ENTITY (NULL)
[this] TABLE
[player] ENTITY (NULL)
[this] TABLE
[player] ENTITY (NULL)
[this] TABLE
DIAGPRINTS
0114:fixme:msvcrt:__clean_type_info_names_internal (00006FFFFDD58788) stub
nswrap: northstar exited with status 3
nswrap: killing xvfb
nswrap: waiting for children to exit
that really need a lot of luck
i fell like i lost a winning ticket
sorry for my bad english :(