Skip to content

Commit

Permalink
Fix IGO64.dll crash
Browse files Browse the repository at this point in the history
  • Loading branch information
wolf109909 committed Oct 25, 2024
1 parent 11fd807 commit 0027c6b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
11 changes: 11 additions & 0 deletions primedev/logging/crashhandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ LONG WINAPI ExceptionFilter(EXCEPTION_POINTERS* pExceptionInfo)

// Needs to be called first as we use the members this sets later on
g_pCrashHandler->SetCrashedModule();

// Somehow IGO64.dll decided to crash with 20% chance, not handling it ourselves
if(g_pCrashHandler->GetCrashedModuleName() == "IGO64.dll")
{
g_pCrashHandler->Unlock();
return EXCEPTION_CONTINUE_SEARCH;
}

// Format
g_pCrashHandler->FormatException();
Expand Down Expand Up @@ -595,5 +602,9 @@ void CCrashHandler::WriteMinidump()
spdlog::error("Failed to write minidump file {}!", stream.str());
}

std::string CCrashHandler::GetCrashedModuleName()
{
return m_svCrashedModule;
}
//-----------------------------------------------------------------------------
CCrashHandler* g_pCrashHandler = nullptr;
3 changes: 3 additions & 0 deletions primedev/logging/crashhandler.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class CCrashHandler
// Minidump
//-----------------------------------------------------------------------------
void WriteMinidump();

std::string GetCrashedModuleName();


private:
PVOID m_hExceptionFilter;
Expand Down
2 changes: 1 addition & 1 deletion primedev/ns_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
#ifndef NORTHSTAR_VERSION
// Turning off clang-format here so it doesn't mess with style as it needs to be this way for regex-ing with CI
// clang-format off
#define NORTHSTAR_VERSION 1,17,6,0
#define NORTHSTAR_VERSION 1,17,7,0
// clang-format on
#endif

0 comments on commit 0027c6b

Please sign in to comment.