-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI error when leaving the lobby too quickly #887
base: main
Are you sure you want to change the base?
Fix UI error when leaving the lobby too quickly #887
Conversation
cc @Bobbyperson you might be able to verify this 👀 |
yippie!!! i'll test when i get home |
Sorry but this fix is not the way to solve #849 i addressed it to myself because the problem does not lie in the |
@@ -2812,6 +2812,9 @@ string function GetParentLoadoutProperty( string loadoutType, string propertyNam | |||
|
|||
int function GetPersistentSpawnLoadoutIndex( entity player, string loadoutType ) | |||
{ | |||
if (!IsValid ( player ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @Zanieon said, this should probably be moved to sh_progression:172 to fix that specific issue, Though its arguably worth having a check here in general since something else could call it wrong (though I'd rather it fail if we are passing invalid entities here, there is no reason we should be)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the check to sh_progression doesn't seem to fix it on my end. I'm probably doing something wrong
Titanfall.2.2024-10-12.22-47-32.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, i was just being stupid. It works now
Fixes #849, using the fix suggested by @Jan200101
How to test:
Without this pr, the game would kick you to the main menu. With this pr, no kick
Before:
https://github.com/user-attachments/assets/2447566b-68ae-4be5-8f22-35b45b7c094b
After:
https://github.com/user-attachments/assets/b59a50b7-ec12-4df5-82a5-78ed66769c70